On Sun, 24 Aug 2008, Vegard Nossum wrote: > > I haven't really used the hlists before, so my first instinct was to > do what is obvious. I do agree that the hlist versions aren't very nice in this regard. The regular lists are much better at moving lists around. > Other than that, I guess open-coding list ops is also not very good > programming practice? :-) Agreed. It would be better if the people who use hlists most (I think that would be networking) would think about this. > But... feel free to submit your own patch. Oh, what am I saying. Silly boy. Next you'll ask me to _test_ any patches I send out. Anyway, I think your patch is likely fine, I just thought it looked a bit odd to have a loop to move a list from one head pointer to another. But regardless, it would need some testing. Daniel? Linus -- To unsubscribe from this list: send the line "unsubscribe kernel-testers" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
