On Thu, 2008-06-19 at 11:13 +0200, Ingo Molnar wrote: > the better fix would be to add likely_prof.o to this list of exceptions > in lib/Makefile: > > ifdef CONFIG_FTRACE > # Do not profile string.o, since it may be used in early boot or vdso > CFLAGS_REMOVE_string.o = -pg > # Also do not profile any debug utilities > CFLAGS_REMOVE_spinlock_debug.o = -pg > CFLAGS_REMOVE_list_debug.o = -pg > CFLAGS_REMOVE_debugobjects.o = -pg > endif > > instead of adding notrace to the source. > > Ingo Here's the fix mentioned above. -- Remove tracing from likely profiling since it could cause recursion if ftrace uses likely/unlikely macro's internally. Signed-off-by: Daniel Walker <dwalker@xxxxxxxxxx> --- lib/Makefile | 2 ++ 1 file changed, 2 insertions(+) Index: linux-2.6.25/lib/Makefile =================================================================== --- linux-2.6.25.orig/lib/Makefile +++ linux-2.6.25/lib/Makefile @@ -15,6 +15,8 @@ CFLAGS_REMOVE_string.o = -pg CFLAGS_REMOVE_spinlock_debug.o = -pg CFLAGS_REMOVE_list_debug.o = -pg CFLAGS_REMOVE_debugobjects.o = -pg +# likely profiling can cause recursion in ftrace, so don't trace it. +CFLAGS_REMOVE_likely_prof.o = -pg endif lib-$(CONFIG_MMU) += ioremap.o -- To unsubscribe from this list: send the line "unsubscribe kernel-testers" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
