On Thu, Sep 30, 2021 at 09:27:43PM +0300, Alexander Popov wrote: > On 30.09.2021 02:31, Andrew Morton wrote: > > On Wed, 29 Sep 2021 22:01:33 +0300 Alexander Popov <alex.popov@xxxxxxxxx> wrote: > > > >> On 29.09.2021 21:58, Alexander Popov wrote: > >> [...] > >> If you are fine with this approach, I will prepare a patch adding the > >> pkill_on_warn sysctl. > > > > Why do we need a boot parameter? Isn't a sysctl all we need for this > > feature? > > I would say we need both sysctl and boot parameter for pkill_on_warn. > That would be consistent with panic_on_warn, ftrace_dump_on_oops and > oops/panic_on_oops. If you want to change it at runtime, just make a sysctl: it will be available as a bootparam since v5.8. See commit 3db978d480e2 ("kernel/sysctl: support setting sysctl parameters from kernel command line") -- Kees Cook