Re: [PATCH] scripts: Add intended executable mode and SPDX license

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 27, 2020 at 03:06:53PM +0200, Solar Designer wrote:
> On Thu, Aug 27, 2020 at 02:54:05PM +0530, Mrinal Pandey wrote:
> >  mode change 100644 => 100755 scripts/gcc-plugins/gen-random-seed.sh
> 
> This is basically the only change relevant to the contribution initially
> made via kernel-hardening, and in my opinion (and I am list admin) isn't
> worth bringing to the list.  Now we have this bikeshed thread in here
> (and I'm guilty for adding to it), and would have more (which I hope
> this message of mine will prevent) if changes to something else in the
> patch(es) are requested (which Greg KH sort of already did).
> 
> I recall we previously had lots of "similar" bikeshedding in here when
> someone was converting the documentation to rST.  The more bikeshedding
> we have, the less actual kernel-hardening work is going to happen,
> because the list gets the reputation of yet another kernel maintenance
> list rather than the place where actual/potential new contributions to
> improve the kernel's security are discussed, and because bikeshedding
> makes the most capable people unsubscribe or stop paying attention.
> 
> How about we remove kernel-hardening from the MAINTAINERS entries it's
> currently in? -
> 
> GCC PLUGINS
> M:      Kees Cook <keescook@xxxxxxxxxxxx>
> R:      Emese Revfy <re.emese@xxxxxxxxx>
> L:      kernel-hardening@xxxxxxxxxxxxxxxxxx
> S:      Maintained
> F:      Documentation/kbuild/gcc-plugins.rst
> F:      scripts/Makefile.gcc-plugins
> F:      scripts/gcc-plugin.sh
> F:      scripts/gcc-plugins/
> 
> LEAKING_ADDRESSES
> M:      Tobin C. Harding <me@xxxxxxxx>
> M:      Tycho Andersen <tycho@xxxxxxxx>
> L:      kernel-hardening@xxxxxxxxxxxxxxxxxx
> S:      Maintained
> T:      git git://git.kernel.org/pub/scm/linux/kernel/git/tobin/leaks.git
> F:      scripts/leaking_addresses.pl
> 
> Alternatively, would this be acceptable? -
> 
> L:      kernel-hardening@xxxxxxxxxxxxxxxxxx (only for messages focused on core functionality, not for maintenance detail)
> 
> I think the latter would be best, if allowed.
> 
> Kees, please comment (so that we'd hopefully not need that next time),
> and if you agree please make a change to MAINTAINERS.

A comment isn't going to really help fix this (much of the CCing is done
by scripts, etc).

I've tended to prefer more emails than missing discussions, and I think
it's not unreasonable to have the list mentioned in MAINTAINERS for
those things. It does, of course, mean that "maintenance" patches get
directed there too, as you say.

If it's really something you'd like to avoid, I can drop those
references. My instinct is to leave it as-is, but the strength of my
opinion is pretty small. Let me know what you prefer...

-- 
Kees Cook



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux