On Wed, 2020-07-22 at 10:56 -0400, Joe Lawrence wrote: > On 7/22/20 10:51 AM, Joe Lawrence wrote: > > On 7/22/20 10:39 AM, Kees Cook wrote: > > > On Wed, Jul 22, 2020 at 11:27:30AM +0200, Miroslav Benes wrote: > > > > Let me CC live-patching ML, because from a quick glance this is > > > > something > > > > which could impact live patching code. At least it invalidates > > > > assumptions > > > > which "sympos" is based on. > > > > > > In a quick skim, it looks like the symbol resolution is using > > > kallsyms_on_each_symbol(), so I think this is safe? What's a good > > > selftest for live-patching? > > > > > > > Hi Kees, > > > > I don't think any of the in-tree tests currently exercise the > > kallsyms/sympos end of livepatching. > > > > On second thought, I mispoke.. The general livepatch code does use > it: > > klp_init_object > klp_init_object_loaded > klp_find_object_symbol > > in which case any of the current kselftests should exercise that. > > % make -C tools/testing/selftests/livepatch run_tests > > -- Joe > Thanks, it looks like this should work for helping me exercise the live patch code paths. I will take a look and get back to you all.