Hi Takashi, On Wed, Jul 08, 2020 at 10:06:28PM +0900, Takashi Sakamoto wrote: > Hi, > > I'm sorry to be late but I was stuck at my work for ALSA control > service programs for audio and music units on IEEE 1394 bus[1]. > > On Sat, May 30, 2020 at 11:08:39AM +0200, Oscar Carter wrote: > > [...] > > Hi, > > > > this is another proposal to achieved the goal of remove function callback > > cast start by me with the first [1] and second [2] versions, and followed > > by the work of Takashi Sakamoto with his first [3] and second [4] versions, > > and the code of Stefan Richter [5]. > > > > The purpose of this third version is to put together all the work done > > until now following the comments of all reviewed patches. > > > > I've added the "Co-developed-by" and "Signed-off-by" tags to give credit to > > Takashi Sakamoto and Stefan Richter if there are no objections. > > In my opinion, it's no need to add my and Stefan's sign-off tag to patch > in which you firstly wrote even if it includes ideas from the others ;) I would like to leave it as is because most of the work is based on your code (Takashi and Stefan). > > [...] > > Anyway this patch looks good to me. I test this patch with libhinoko and > find no regression. > > Reviewed-by: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx> > Testeb-by: Takashi Sakamoto<o-takashi@xxxxxxxxxxxxx> > > > [1] [RFT] ALSA control service programs for Digidesign Digi 002/003 family > and Tascam FireWire series > https://mailman.alsa-project.org/pipermail/alsa-devel/2020-July/170331.html > > Thanks > > Takashi Sakamoto Regards, Oscar Carter