On Tue, 2020-07-07 at 23:16 +0000, Luck, Tony wrote: > > Signed-off-by: Kristen Carlson Accardi <kristen@xxxxxxxxxxxxxxx> > > Reviewed-by: Tony Luck <tony.luck@xxxxxxxxx> > > Tested-by: Tony Luck <tony.luck@xxxxxxxxx> > > I'll happily review and test again ... but since you've made > substantive > changes, you should drop these tags until I do. Will do - thanks! If nobody thinks this is a horrible direction, I'll clean up this patch and submit it with the rest as part of v4. > > FWIW I think random order is a good idea. Do you shuffle once? > Or every time somebody opens /proc/kallsyms? I am shuffling every single time that somebody opens /proc/kallsyms - this is because it's possible that somebody has loaded modules or bpf stuff and there may be new/different symbols to display.