On Sun, May 10, 2020 at 3:17 PM Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
> The commit message should say "lib/crypto", not Zinc. Nothing in the source
> tree actually says Zinc, so it will confuse people who haven't read all the
> previous discussions.
Old commit message from a few years ago. Will adjust.
>
> > /* read file to kernel and decrypt */
> > - ret = kernel_read(file, buf->virt, enclen, &pos);
> > + ret = kernel_read(file, buf, enclen, &pos);
> > if (ret >= 0 && ret != enclen) {
> > ret = -EIO;
> > goto err_fput;
> > + } else if (ret < 0) {
> > + goto err_fput;
> > }
>
> It would make sense to write this as the following, to make it consistent with
> how the return value of kernel_write() is checked in big_key_preparse():
>
> ret = kernel_read(file, buf, enclen, &pos);
> if (ret != enclen) {
> if (ret >= 0)
> ret = -ENOMEM;
> goto err_fput;
> }
Will do, and will send a v3 with your reviewed-by.
Jason
