On Mon, 20 Apr 2020 18:17:28 +0100 Will Deacon <will@xxxxxxxxxx> wrote: > > +ifdef CONFIG_SHADOW_CALL_STACK > > +CC_FLAGS_SCS := -fsanitize=shadow-call-stack > > +KBUILD_CFLAGS += $(CC_FLAGS_SCS) > > +export CC_FLAGS_SCS > > +endif > > CFLAGS_SCS would seem more natural to me, although I see ftrace does it this > way. The CC_FLAGS_FTRACE was added by Heiko Carstens, and the "CC_FLAGS_" appears to be a common usage in s390 :-) That said, I like the CC_FLAGS_ notation, because the Linux build system uses CFLAGS_* as commands: CFLAGS_foo.o = x CFLAGS_REMOVE_foo.o = y And "CC_FLAGS_" is only for new flags and easy to search for. -- Steve
