On Mon, Mar 30, 2020 at 04:30:20PM -0700, Paul E. McKenney wrote: > On Tue, Mar 24, 2020 at 03:36:31PM +0000, Will Deacon wrote: > > There is no need to use WRITE_ONCE() when inserting into a non-RCU > > protected list. > > > > Cc: Paul E. McKenney <paulmck@xxxxxxxxxx> > > Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx> > > Signed-off-by: Will Deacon <will@xxxxxxxxxx> > > OK, I will bite... Why "unsigned long" instead of "uintptr_t"? I just did that for consistency with the rest of the file, e.g. hlist_bl_first(), hlist_bl_set_first(), hlist_bl_empty() and __hlist_bl_del() all cast to 'unsigned long', yet only hlist_bl_add_before() was using 'uintptr_t' > Not that it matters in the context of the Linux kernel, so: > > Reviewed-by: Paul E. McKenney <paulmck@xxxxxxxxxx> Thanks, Paul! Will
