On Thu, Mar 26, 2020 at 11:06 AM Kees Cook <keescook@xxxxxxxxxxxx> wrote: > > On Wed, Mar 25, 2020 at 12:14:32PM +0900, Masahiro Yamada wrote: > > Add -Wall to catch more warnings for C++ host programs. > > > > When I submitted the previous version, the 0-day bot reported > > -Wc++11-compat warnings for old GCC: > > > > HOSTCXX -fPIC scripts/gcc-plugins/latent_entropy_plugin.o > > In file included from /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/tm.h:28:0, > > from scripts/gcc-plugins/gcc-common.h:15, > > from scripts/gcc-plugins/latent_entropy_plugin.c:78: > > /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/config/elfos.h:102:21: warning: C++11 requires a space between string literal and macro [-Wc++11-compat] > > fprintf ((FILE), "%s"HOST_WIDE_INT_PRINT_UNSIGNED"\n",\ > > ^ > > /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/config/elfos.h:170:24: warning: C++11 requires a space between string literal and macro [-Wc++11-compat] > > fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ > > ^ > > In file included from /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/tm.h:42:0, > > from scripts/gcc-plugins/gcc-common.h:15, > > from scripts/gcc-plugins/latent_entropy_plugin.c:78: > > /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/defaults.h:126:24: warning: C++11 requires a space between string literal and macro [-Wc++11-compat] > > fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ > > ^ > > > > The source of the warnings is in the plugin headers, so we have no > > control of it. I just suppressed them by adding -Wno-c++11-compat to > > scripts/gcc-plugins/Makefile. > > > > Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx> > > Acked-by: Kees Cook <keescook@xxxxxxxxxxxx> > > -Kees Applied to linux-kbuild. -- Best Regards Masahiro Yamada
