> On Mar 5, 2020, at 9:52 PM, Tycho Andersen <tycho@xxxxxxxx> wrote: > > On Thu, Mar 05, 2020 at 10:56:29AM -0500, Arvind Sankar wrote: >>> On Thu, Mar 05, 2020 at 04:49:22PM +0100, John Paul Adrian Glaubitz wrote: >>> On 3/5/20 4:46 PM, Arvind Sankar wrote: >>>> Not really too late. I can do s/pr_info/pr_devel and resubmit. >>>> >>>> parisc for eg actually hides this in #if 0 rather than deleting the >>>> code. >>>> >>>> Kees, you fine with that? >>> >>> But wasn't it removed for all the other architectures already? Or are these >>> changes not in Linus' tree yet? >>> >>> Adrian >> >> The ones mentioned in the commit message, yes, those are long gone. But >> I don't see any reason why the remaining ones (there are 6 left that I >> submitted patches just now for) couldn't switch to pr_devel instead. > > If you do happen to re-send with pr_debug() instead, feel free to add > my ack to that series as well. Since it already got removed for most other architectures, I don’t think it makes much sense to keep it for consistency. I just didn’t understand why it was made configurable for debugging purposes in the first place. Also, many distributions disable access to the kernel buffer for unprivileged users anyway. Adrian
