On Thu, Jan 16, 2020 at 9:39 AM Will Deacon <will@xxxxxxxxxx> wrote: > > On Fri, Dec 06, 2019 at 02:13:44PM -0800, Sami Tolvanen wrote: > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > index b1b4476ddb83..49e5f94ff4af 100644 > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -149,7 +149,7 @@ config ARM64 > > select HAVE_FTRACE_MCOUNT_RECORD > > select HAVE_FUNCTION_TRACER > > select HAVE_FUNCTION_ERROR_INJECTION > > - select HAVE_FUNCTION_GRAPH_TRACER > > + select HAVE_FUNCTION_GRAPH_TRACER if !SHADOW_CALL_STACK > > select HAVE_GCC_PLUGINS > > select HAVE_HW_BREAKPOINT if PERF_EVENTS > > select HAVE_IRQ_TIME_ACCOUNTING > > I think this is the wrong way around, as we support the graph tracer > today and so I think SHADOW_CALL_STACK should depend on !GRAPH_TRACER > and possibly even EXPERT until this is resolved. Sure, sounds reasonable. I'll change this in the next version. Sami