On Fri, Nov 15, 2019 at 02:16:10PM +0800, Greg Kroah-Hartman wrote: > On Thu, Nov 14, 2019 at 09:39:00PM -0800, Kees Cook wrote: > > In order to make the entire kernel usable under Clang's Control Flow > > Integrity protections, function prototype casts need to be avoided > > because this will trip CFI checks at runtime (i.e. a mismatch between > > the caller's expected function prototype and the destination function's > > prototype). Many of these cases can be found with -Wcast-function-type, > > which found that the rtl wifi drivers had a bunch of needless function > > casts. Remove function casts for tasklet callbacks in the various drivers. > > > > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx> > > --- > > drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c | 3 +-- > > drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | 3 +-- > > drivers/staging/rtl8188eu/include/rtl8188e_recv.h | 2 +- > > drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 2 +- > > drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 4 ++-- > > drivers/staging/rtl8192e/rtllib_softmac.c | 7 +++---- > > .../staging/rtl8192u/ieee80211/ieee80211_softmac.c | 7 +++---- > > drivers/staging/rtl8192u/r8192U_core.c | 8 ++++---- > > drivers/staging/rtl8712/rtl8712_recv.c | 11 +++++------ > > drivers/staging/rtl8712/rtl871x_xmit.c | 5 ++--- > > drivers/staging/rtl8712/rtl871x_xmit.h | 2 +- > > drivers/staging/rtl8712/usb_ops_linux.c | 4 ++-- > > drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 11 ++++------- > > 13 files changed, 30 insertions(+), 39 deletions(-) > > This fails to apply to my staging-next branch of staging.git. Can you > rebase and resend? Ah, hrm, sorry. I think I was based on Linus's master. I will adjust! -- Kees Cook
