Hi Sami,
On Mon, 28 Oct 2019 at 16:20 Sami Tolvanen <samitolvanen@xxxxxxxxxx> wrote:
Hi Joe,
On Sat, Oct 26, 2019 at 8:57 AM Joe Perches <joe@xxxxxxxxxxx> wrote:
> > +#if __has_feature(shadow_call_stack)
> > +# define __noscs __attribute__((no_sanitize("shadow-call-stack")))
>
> __no_sanitize__
Sorry, I missed your earlier message about this. I'm following Clang's
documentation for the attribute:
https://clang.llvm.org/docs/ShadowCallStack.html#attribute-no-sanitize-shadow-call-stack
Although __no_sanitize__ seems to work too. Is there a particular
reason to prefer that form over the one in the documentation?
We decided to do it like that when I introduced compiler_attributes.h.
Given it is hidden behind a definition, we don't care about which one we use internally; therefore the idea was to avoid clashes as much as possible with other names/definitions/etc.
The syntax is supported in the compilers we care about (for docs on attributes, the best reference is GCC's by the way).
Cheers,
Miguel
Cheers,
Miguel
Miguel
