On Wed, 2019-07-24 at 18:17 +0000, Gote, Nitin R wrote: > Hi, Hi again. [] > > > > > 3. Deprecate strncpy() in favor of strscpy() or strscpy_pad(). Please remember there does not exist a single actual use of strscpy_pad in the kernel sources and no apparent real need for it. I don't find one anyway. > Could you please give your opinion on below comment. > > > But, if the destination buffer needs extra NUL-padding for remaining size of > > destination, then safe replacement is strscpy_pad(). Right? If yes, then what > > is your opinion on below change : > > > > "strncpy" => "strscpy, strcpy_pad - for non-NUL-terminated uses, > > strncpy() dst should be __nonstring", > > > If you agree on this, then I will include this change in next patch version. Two things: The kernel-doc documentation uses dest not dst. I think stracpy should be preferred over strscpy.
