On Sun, Jul 21, 2019 at 07:55:33PM +0200, Romain Perier wrote: > Ok, thanks for these explanations. (Reminder: please use inline-context email replies instead of top-posting, this makes threads much easier to read.) > The task is in progress, you can follow the status here : > https://salsa.debian.org/rperier-guest/linux-tree/tree/tasklet_init > (the commit messages are tagged WIP, I will add a long message and > signed-off-by , when it's done) Looks good! I wonder if you're able to use Coccinelle to generate the conversion patch? There appear to be just under 400 callers of tasklet_init(), which is a lot to type by hand. :) Also, have you found any other tasklet users that are NOT using tasklet_init()? The timer_struct conversion had about three ways to do initialization. :( -- Kees Cook