On Mon, May 6, 2019 at 2:32 AM Allen <allen.lkml@xxxxxxxxx> wrote: > I have been toying with the idea of "refactor tasklets to avoid > unsigned long argument" since Kees listed on KSPP wiki. I wanted to > and have kept the implementation very simple. Let me know what you > guys think. > > Note: I haven't really done much of testing besides boot testing with small > set of files moved to the new api. > > My only concern with the implementation is, in the kernel the combination > of tasklet_init/DECLARE_TAKSLET is seen in over ~400 plus files. > With the change(dropping unsigned long argument) there will be huge list > of patches migrating to the new api. Yeah, this is the main part of the work for making this change. When the timer API got changed, I had to do a two-stage change so we could convert the users incrementally, and then finalize the API change to drop the old style. Beyond that, yeah, everything you sent looks good. It's just the matter of building a series of patches to do it without breaking the world. (Though if it's small enough, maybe it could be a single patch? But I doubt that would be doable...) -- Kees Cook
