On Mon, Feb 25, 2019 at 6:17 AM Tobin C. Harding <tobin@xxxxxxxxxx> wrote: > > We have a function to copy strings safely and we have a function to copy > strings and zero the tail of the destination (if source string is > shorter than destination buffer) but we do not have a function to do > both at once. This means developers must write this themselves if they > desire this functionality. This is a chore, and also leaves us open to > off by one errors unnecessarily. > > Add a function that calls strscpy() then memset()s the tail to zero if > the source string is shorter than the destination buffer. > > Add test module for the new code. > --- /dev/null > +++ b/lib/test_strscpy.c > @@ -0,0 +1,175 @@ > +// SPDX-License-Identifier: GPL-2.0 > +MODULE_LICENSE("GPL"); License mismatch. Do we need a separate module for this test? -- With Best Regards, Andy Shevchenko