On 2/28/25 6:58 PM, Caleb Sander Mateos wrote: > On Fri, Feb 28, 2025 at 5:40 PM Pavel Begunkov <asml.silence@xxxxxxxxx> wrote: >> >> On 3/1/25 00:16, Caleb Sander Mateos wrote: >>> Call io_find_buf_node() to avoid duplicating it in io_nop(). >> >> IORING_NOP_FIXED_BUFFER interface looks odd, instead of pretending >> to use a buffer, it basically pokes directly into internal infra, >> it's not something userspace should be able to do. > > I assumed it was just for benchmarking the overhead of fixed buffer > lookup. Since a normal IORING_OP_NOP doesn't use any buffer, it makes > sense for IORING_NOP_FIXED_BUFFER not to do anything with the fixed > buffer either. That's exactly right, it's just for benchmarking purposes. NOP doesn't transfer anything, obviously, so it doesn't do anything with it. -- Jens Axboe
