Re: [PATCH 1/1] io_uring: compile out compat param passing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>  #ifdef CONFIG_COMPAT
> -       if (req->ctx->compat)
> +       if (io_is_compat(req->ctx))
>                 return io_iov_compat_buffer_select_prep(rw);
>  #endif

Should the #ifdef CONFIG_COMPAT be removed here since io_is_compat() already
accounts for it?

> @@ -120,7 +120,7 @@ static int __io_import_iovec(int ddir, struct io_kiocb *req,
>                 nr_segs = 1;
>         }
>         ret = __import_iovec(ddir, buf, sqe_len, nr_segs, &iov, &io->iter,
> -                               req->ctx->compat);
> +                               io_is_compat(req->ctx));

Should we also update other places that use ctx->compat (e.g., rsrc.c, net.c,
uring_cmd.c) to use the new io_is_compat() helper for consistency?




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux