Re: [PATCH] io_uring: pass struct io_tw_state by value

[Pavel Begunkov <asml.silence@xxxxxxxxx>]

On 2/11/25 21:45, Caleb Sander Mateos wrote:
...
> --- a/io_uring/waitid.c
> +++ b/io_uring/waitid.c
> @@ -14,11 +14,11 @@
>   #include "io_uring.h"
>   #include "cancel.h"
>   #include "waitid.h"
>   #include "../kernel/exit.h"
>   
> -static void io_waitid_cb(struct io_kiocb *req, struct io_tw_state *ts);
> +static void io_waitid_cb(struct io_kiocb *req, struct io_tw_state ts);
>   
>   #define IO_WAITID_CANCEL_FLAG	BIT(31)
>   #define IO_WAITID_REF_MASK	GENMASK(30, 0)
>   
>   struct io_waitid {
> @@ -129,11 +129,11 @@ static void io_waitid_complete(struct io_kiocb *req, int ret)
>   
>   	ret = io_waitid_finish(req, ret);
>   	if (ret < 0)
>   		req_set_fail(req);
>   	io_req_set_res(req, ret, 0);
> -	io_req_task_complete(req, &ts);

This thing will need to be fixed first


> +	io_req_task_complete(req, ts);
>   }

--
Pavel Begunkov