Re: [PATCH v11 07/10] block: introduce BIP_CHECK_GUARD/REFTAG/APPTAG bip_flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 03, 2025 at 08:09:48PM +0530, Anuj Gupta wrote:
> +	if (bi->csum_type == BLK_INTEGRITY_CSUM_IP)
> +		bip->bip_flags |= BIP_IP_CHECKSUM;

I don't think this part will work, but it's a bug since day one of
the nvmet PI support:  NVMe doesn't support IP checksum, but in this
case we'd expect the remoe side to supply it.  So the setup path
needs to check for a support csum type.  I can look into that as a
separate fix.

We'll also need to set the BIP_CHECK_GUARD flag here I think.





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux