On 1/28/25 13:39, Max Kellermann wrote:
This eliminates several redundant reads, some of which probably cannot be optimized away by the compiler.
Let's not, it hurts readability with no clear benefits. In most cases the compiler will be able to optimise it just where it matters, and in cold paths we're comparing the overhead of reading a cached variable with taking locks and doing indirect calls, and even then it'd likely need to be saved onto the stack and loaded back. The only place where it might be worth it is io_issue_sqe(), and even then I'd doubt it. -- Pavel Begunkov
