Re: [PATCH net-next v10 01/22] net: make page_pool_ref_netmem work with net iovs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/16/25 02:48, Jakub Kicinski wrote:
On Thu, 16 Jan 2025 02:12:06 +0000 Pavel Begunkov wrote:
On 1/16/25 00:30, Jakub Kicinski wrote:
On Wed,  8 Jan 2025 14:06:22 -0800 David Wei wrote:
From: Pavel Begunkov <asml.silence@xxxxxxxxx>

page_pool_ref_netmem() should work with either netmem representation, but
currently it casts to a page with netmem_to_page(), which will fail with
net iovs. Use netmem_get_pp_ref_count_ref() instead.

This is a fix, right? If we try to coalesce a cloned netmem skb
we'll crash.

True, I missed it it's actually used.

I'll add:

Fixes: 8ab79ed50cf1 ("page_pool: devmem support")

and we'll send it to Linus tomorrow. Hope that's okay.

Sounds good to me

--
Pavel Begunkov





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux