On Wed, 15 Jan 2025 16:35:21 -0800 Jakub Kicinski wrote: > On Wed, 8 Jan 2025 14:06:26 -0800 David Wei wrote: > > Export page_pool_set_dma_addr_netmem() in page_pool/helpers.h. This is > > needed by memory provider implementations that are outside of net/ to be > > able to set the dma addrs on net_iovs during alloc/free. > > Please keep helpers.h focused on the driver-facing API. > Maybe create a new header page_pool/private.h would be > sufficiently suggestive. Or you can put it in the memory_provider one from the next patch.