On 1/7/25 10:56, Luis Henriques wrote:
Hi Bernd,
On Tue, Jan 07 2025, Bernd Schubert wrote:
This adds basic support for ring SQEs (with opcode=IORING_OP_URING_CMD).
For now only FUSE_IO_URING_CMD_REGISTER is handled to register queue
entries.
Please find below two (minor) comments I had already for v8. Hopefully
this time I'll finish reviewing rev v9!
Thank you very much, both fixed in v10 branch, I will wait a bit for
further reviews before sending out v10.
I think the leak of ring_ent in error cases is actually new v9 - I think
I wanted to move up error checking (before the allocation) and then forgot
about that :/ Done now, no need to allocate at all if the IOV is not correct.
Thanks,
Bernd
