On 1/3/25 8:02 AM, Mark Harmstone wrote: > Version 4 of mine and Jens' patches, to make sure that when our io_uring > function gets called a second time, it doesn't accidentally read > something from userspace that's gone out of scope or otherwise gotten > corrupted. > > I sent a version 3 on December 17, but it looks like that got forgotten > about over Christmas (unsurprisingly). Version 4 fixes a problem that I > noticed, namely that we weren't taking a copy of the iovs, which also > necessitated creating a struct to store these things in. This does > simplify things by removing the need for the kmemdup, however. > > I also have a patch for io_uring encoded writes ready to go, but it's > waiting on some of the stuff introduced here. Looks fine to me, and we really should get this into 6.13. The encoded reads are somewhat broken without it, violating the usual expectations on how persistent passed in data should be. -- Jens Axboe
