Re: [PATCH net-next v9 08/20] net: expose page_pool_{set,clear}_pp_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 21 Dec 2024 01:07:44 +0000 Pavel Begunkov wrote:
> >> Memory providers need to set page pool to its net_iovs on allocation, so
> >> expose page_pool_{set,clear}_pp_info to providers outside net/.  
> > 
> > I'd really rather not expose such low level functions in a header
> > included by every single user of the page pool API.  
> 
> Are you fine if it's exposed in a new header file?

I guess.

I'm uncomfortable with the "outside net/" phrasing of the commit
message. Nothing outside net should used this stuff. Next we'll have
a four letter subsystem abusing it and claiming that it's in a header
so it's a public.

Maybe we should have a conversation about whether io_uring/zcrx.c 
is considered part of networking, whether all patches will get cross
posted and need to get acks from both sides etc. Save ourselves
unpleasant misunderstandings.




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux