Micron Confidential Hi, I was under the impression that passing write hints via fcntl() on any legacy filesystem stays. The hint is attached to the inode, and the fs simply picks it up from there when sending it down with write related to that inode. Aka per file write hint. I am right? Pierre Micron Confidential +AD4- -----Original Message----- +AD4- From: Christoph Hellwig +ADw-hch+AEA-lst.de+AD4- +AD4- Sent: Monday, December 9, 2024 4:52 AM +AD4- To: Keith Busch +ADw-kbusch+AEA-meta.com+AD4- +AD4- Cc: axboe+AEA-kernel.dk+ADs- hch+AEA-lst.de+ADs- linux-block+AEA-vger.kernel.org+ADs- linux- +AD4- nvme+AEA-lists.infradead.org+ADs- linux-fsdevel+AEA-vger.kernel.org+ADs- io- +AD4- uring+AEA-vger.kernel.org+ADs- sagi+AEA-grimberg.me+ADs- asml.silence+AEA-gmail.com+ADs- Keith +AD4- Busch +ADw-kbusch+AEA-kernel.org+AD4- +AD4- Subject: +AFs-EXT+AF0- Re: +AFs-PATCHv11 00/10+AF0- block write streams with nvme fdp +AD4- +AD4- CAUTION: EXTERNAL EMAIL. Do not click links or open attachments unless you +AD4- recognize the sender and were expecting this message. +AD4- +AD4- +AD4- Note: I skipped back to this because v12 only had the log vs v11. +AD4- +AD4- On Thu, Dec 05, 2024 at 05:52:58PM -0800, Keith Busch wrote: +AD4- +AD4- +AD4- +AD4- Not mixing write hints usage with write streams. This effectively +AD4- +AD4- abandons any attempts to use the existing fcntl API for use with +AD4- +AD4- filesystems in this series. +AD4- +AD4- That's not true as far as I can tell given that this is basically the architecture +AD4- from my previous posting. The block code still maps the rw hints into write +AD4- streams, and file systems can do exactly the same. +AD4- You just need to talk to the fs maintainers and convince them it's a good thing +AD4- for their particular file system. Especially for simple file systems that task +AD4- should not be too hard, even if they might want to set a stream or two aside +AD4- for fs usage. Similarly a file system can implement the stream based API. +AD4-