On Tue, Nov 19, 2024 at 11:17:36AM -0700, Keith Busch wrote:
> > + if (le32_to_cpu(configs[result.fdpcidx].nrg) > 1) {
> > + dev_warn(ns->ctrl->device, "FDP NRG > 1 not supported\n");
>
> Why not support multiple reclaim groups?
Can you come up with a sane API for that? And can you find devices in
the wild that actually support it?
> > + ns->head->runs = le64_to_cpu(configs[result.fdpcidx].runs);
>
> The config descriptors are variable length, so you can't just index into
> it. You have to read each index individually to get the next index's offset.
> Something like:
Indeed. The current code only works when the first config is selected.
