On Mon, Nov 18, 2024 at 05:06:46PM -0500, Sasha Levin wrote:
Hi Jens, Thomas, On Mon, Nov 18, 2024 at 07:22:59AM -0700, Jens Axboe wrote:hexue (1): io_uring: add support for hybrid IOPOLLAfter merging of this pull request into linus-next, I've started seeing build errors: /builds/linux/io_uring/rw.c: In function 'io_hybrid_iopoll_delay': /builds/linux/io_uring/rw.c:1179:2: error: implicit declaration of function 'hrtimer_init_sleeper_on_stack'; did you mean 'hrtimer_setup_sleeper_on_stack'? [-Werror=implicit-function-declaration] hrtimer_init_sleeper_on_stack(&timer, CLOCK_MONOTONIC, mode); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ hrtimer_setup_sleeper_on_stack This is because 01ee194d1aba ("io_uring: add support for hybrid IOPOLL") adds a call to hrtimer_init_sleeper_on_stack() which was removed earlier today in Thomas's PR[1], specifically in commit f3bef7aaa6c8 ("hrtimers: Delete hrtimer_init_sleeper_on_stack()").
Linus, Looks like this is a simple s/hrtimer_init_sleeper_on_stack/hrtimer_setup_sleeper_on_stack , so this issue could be addressed by replacing the new call with hrtimer_setup_sleeper_on_stack() either in the io_uring or the timers/core merge, whichever you pull last. -- Thanks, Sasha
