On Mon, Oct 14, 2024 at 06:18:24PM +0100, Mark Harmstone wrote: > Change btrfs_encoded_read_regular_fill_pages so that it takes a callback > rather than waiting, and add new helper function btrfs_encoded_read_wait_cb > to match the existing behaviour. Please avoid callbacks and function pointers when it's in the same subsystem. Pass some enum and do a switch inside the function, or wrap it to a helper if needed. Since spectre/meltdown function pointers in kernel have been removed when possible and I don't see a strong reason for it here.