On 10/11/24 9:45 AM, Ming Lei wrote: > On Fri, Oct 11, 2024 at 08:41:03AM -0600, Jens Axboe wrote: >> On 10/11/24 8:20 AM, Ming Lei wrote: >>> On Fri, Oct 11, 2024 at 07:24:27AM -0600, Jens Axboe wrote: >>>> On 10/10/24 9:07 PM, Ming Lei wrote: >>>>> On Thu, Oct 10, 2024 at 08:39:12PM -0600, Jens Axboe wrote: >>>>>> On 10/10/24 8:30 PM, Ming Lei wrote: >>>>>>> Hi Jens, >>>>>>> >>>>>>> On Thu, Oct 10, 2024 at 01:31:21PM -0600, Jens Axboe wrote: >>>>>>>> Hi, >>>>>>>> >>>>>>>> Discussed this with Pavel, and on his suggestion, I tried prototyping a >>>>>>>> "buffer update" opcode. Basically it works like >>>>>>>> IORING_REGISTER_BUFFERS_UPDATE in that it can update an existing buffer >>>>>>>> registration. But it works as an sqe rather than being a sync opcode. >>>>>>>> >>>>>>>> The idea here is that you could do that upfront, or as part of a chain, >>>>>>>> and have it be generically available, just like any other buffer that >>>>>>>> was registered upfront. You do need an empty table registered first, >>>>>>>> which can just be sparse. And since you can pick the slot it goes into, >>>>>>>> you can rely on that slot afterwards (either as a link, or just the >>>>>>>> following sqe). >>>>>>>> >>>>>>>> Quick'n dirty obviously, but I did write a quick test case too to verify >>>>>>>> that: >>>>>>>> >>>>>>>> 1) It actually works (it seems to) >>>>>>> >>>>>>> It doesn't work for ublk zc since ublk needs to provide one kernel buffer >>>>>>> for fs rw & net send/recv to consume, and the kernel buffer is invisible >>>>>>> to userspace. But __io_register_rsrc_update() only can register userspace >>>>>>> buffer. >>>>>> >>>>>> I'd be surprised if this simple one was enough! In terms of user vs >>>>>> kernel buffer, you could certainly use the same mechanism, and just >>>>>> ensure that buffers are tagged appropriately. I need to think about that >>>>>> a little bit. >>>>> >>>>> It is actually same with IORING_OP_PROVIDE_BUFFERS, so the following >>>>> consumer OPs have to wait until this OP_BUF_UPDATE is completed. >>>> >>>> See below for the registered vs provided buffer confusion that seems to >>>> be a confusion issue here. >>>> >>>>> Suppose we have N consumers OPs which depends on OP_BUF_UPDATE. >>>>> >>>>> 1) all N OPs are linked with OP_BUF_UPDATE >>>>> >>>>> Or >>>>> >>>>> 2) submit OP_BUF_UPDATE first, and wait its completion, then submit N >>>>> OPs concurrently. >>>> >>>> Correct >>>> >>>>> But 1) and 2) may slow the IO handing. In 1) all N OPs are serialized, >>>>> and 1 extra syscall is introduced in 2). >>>> >>>> Yes you don't want do do #1. But the OP_BUF_UPDATE is cheap enough that >>>> you can just do it upfront. It's not ideal in terms of usage, and I get >>>> where the grouping comes from. But is it possible to do the grouping in >>>> a less intrusive fashion with OP_BUF_UPDATE? Because it won't change any >>> >>> The most of 'intrusive' change is just on patch 4, and Pavel has commented >>> that it is good enough: >>> >>> https://lore.kernel.org/linux-block/ZwZzsPcXyazyeZnu@fedora/T/#m551e94f080b80ccbd2561e01da5ea8e17f7ee15d >> >> At least for me, patch 4 looks fine. The problem occurs when you start >> needing to support this different buffer type, which is in patch 6. I'm >> not saying we can necessarily solve this with OP_BUF_UPDATE, I just want >> to explore that path because if we can, then patch 6 turns into "oh >> let's just added registered/fixed buffer support to these ops that don't >> currently support it". And that would be much nicer indeed. > > OK, in my local V7, the buffer type is actually aligned with > BUFFER_SELECT from both interface & use viewpoint, since member SQE > have three empty flags available. > > I will post V7 for review. OK, I'll take a look once posted. >>>> of the other ops in terms of buffer consumption, they'd just need fixed >>>> buffer support and you'd flag the buffer index in sqe->buf_index. And >>>> the nice thing about that is that while fixed/registered buffers aren't >>>> really used on the networking side yet (as they don't bring any benefit >>>> yet), adding support for them could potentially be useful down the line >>>> anyway. >>> >>> With 2), two extra syscalls are added for each ublk IO, one is provide >>> buffer, another is remove buffer. The two syscalls have to be sync with >>> consumer OPs. >>> >>> I can understand the concern, but if the change can't improve perf or >>> even slow things done, it loses its value. >> >> It'd be one extra syscall, as the remove can get bundled with the next >> add. But your point still stands, yes it will add extra overhead, > > It can't be bundled. Don't see why not, but let's review v7 and see what comes up. > And the kernel buffer is blk-mq's request pages, which is per tag. > > Such as, for ublk-target, IO comes to tag 0, after this IO(tag 0) is > handled, how can we know if there is new IO comes to tag 0 immediately? :-) Gotcha, yeah sounds like that needs to remain a kernel buffer. >> although be it pretty darn minimal. I'm actually more concerned with the >> complexity for handling it. While the OP_BUF_UPDATE will always >> complete immediately, there's no guarantee it's the next cqe you pull >> out when peeking post submission. >> >>>>> The same thing exists in the next OP_BUF_UPDATE which has to wait until >>>>> all the previous buffer consumers are done. So the same slow thing are >>>>> doubled. Not mention the application will become more complicated. >>>> >>>> It does not, you can do an update on a buffer that's already inflight. >>> >>> UPDATE may not match the case, actually two OPs are needed, one is >>> provide buffer OP and the other is remove buffer OP, both have to deal >>> with the other subsystem(ublk). Remove buffer needs to be done after all >>> consumer OPs are done immediately. >> >> You don't necessarily need the remove. If you always just use the same >> slot for these, then the OP_BUF_UPDATE will just update the current >> location. > > The buffer is per tag, and can't guarantee to be reused immediately, > otherwise it isn't zero copy any more. Don't follow this one either. As long as reuse keeps existing IO fine, then it should be fine? I'm not talking about reusing the buffer, just the slot it belongs to. >>>> would be totally fine in terms of performance. OP_BUF_UPDATE will >>>> _always_ completely immediately and inline, which means that it'll >>>> _always_ be immediately available post submission. The only think you'd >>>> ever have to worry about in terms of failure is a badly formed request, >>>> which is a programming issue, or running out of memory on the host. >>>> >>>>> Also it makes error handling more complicated, io_uring has to remove >>>>> the kernel buffer when the current task is exit, dependency or order with >>>>> buffer provider is introduced. >>>> >>>> Why would that be? They belong to the ring, so should be torn down as >>>> part of the ring anyway? Why would they be task-private, but not >>>> ring-private? >>> >>> It is kernel buffer, which belongs to provider(such as ublk) instead >>> of uring, application may panic any time, then io_uring has to remove >>> the buffer for notifying the buffer owner. >> >> But it could be an application buffer, no? You'd just need the >> application to provide it to ublk and have it mapped, rather than have >> ublk allocate it in-kernel and then use that. > > The buffer is actually kernel 'request/bio' pages of /dev/ublkbN, and now we > forward and borrow it to io_uring OPs(fs rw, net send/recv), so it can't be > application buffer, not same with net rx. So you borrow the kernel pages, but presumably these are all from O_DIRECT and have a user mapping? >>> In concept grouping is simpler because: >>> >>> - buffer lifetime is aligned with group leader lifetime, so we needn't >>> worry buffer leak because of application accidental exit >> >> But if it was an application buffer, that would not be a concern. > > Yeah, but storage isn't same with network, here application buffer can't > support zc. Maybe I'm dense, but can you expand on why that's the case? >> I do like the concept of the ephemeral buffer, the downside is that we >> need per-op support for it too. And while I'm not totally against doing > > Can you explain per-op support a bit? > > Now the buffer has been provided by one single uring command. I mean the need to do: + if (req->flags & REQ_F_GROUP_KBUF) { + ret = io_import_group_kbuf(req, rw->addr, rw->len, ITER_SOURCE, + &io->iter); + if (unlikely(ret)) + return ret; + } for picking such a buffer. >> that, it would be lovely if we could utilize and existing mechanism for >> that rather than add another one. > > If existing mechanism can cover everything, our linux may not progress any > more. That's not what I mean at all. We already have essentially three ways to get a buffer destination for IO: 1) Just pass in an uaddr+len or an iovec 2) Set ->buf_index, the op needs to support this separately to grab a registered buffer for IO. 3) For pollable stuff, provided buffers, either via the ring or the legacy/classic approach. This adds a 4th method, which shares the characteristics of 2+3 that the op needs to support it. This is the whole motivation to poke at having a way to use the normal registered buffer table for this, because then this falls into method 2 above. I'm not at all saying "oh we can't add this new feature", the only thing I'm addressing is HOW we do that. I don't think anybody disagrees that we need zero copy for ublk, and honestly I would love to see that sooner rather than later! >>>>>> There are certainly many different ways that can get propagated which >>>>>> would not entail a complicated mechanism. I really like the aspect of >>>>>> having the identifier being the same thing that we already use, and >>>>>> hence not needing to be something new on the side. >>>>>> >>>>>>> Also multiple OPs may consume the buffer concurrently, which can't be >>>>>>> supported by buffer select. >>>>>> >>>>>> Why not? You can certainly have multiple ops using the same registered >>>>>> buffer concurrently right now. >>>>> >>>>> Please see the above problem. >>>>> >>>>> Also I remember that the selected buffer is removed from buffer list, >>>>> see io_provided_buffer_select(), but maybe I am wrong. >>>> >>>> You're mixing up provided and registered buffers. Provided buffers are >>>> ones that the applications gives to the kernel, and the kernel grabs and >>>> consumes them. Then the application replenishes, repeat. >>>> >>>> Registered buffers are entirely different, those are registered with the >>>> kernel and we can do things like pre-gup the pages so we don't have to >>>> do them for every IO. They are entirely persistent, any multiple ops can >>>> keep using them, concurrently. They don't get consumed by an IO like >>>> provided buffers, they remain in place until they get unregistered (or >>>> updated, like my patch) at some point. >>> >>> I know the difference. >> >> But io_provided_buffer_select() has nothing to do with registered/fixed >> buffers or this use case, the above "remove from buffer list" is an >> entirely different buffer concept. So there's some confusion here, just >> wanted to make that clear. >> >>> The thing is that here we can't register the kernel buffer in ->prep(), >>> and it has to be provided in ->issue() of uring command. That is similar >>> with provided buffer. >> >> What's preventing it from registering it in ->prep()? It would be a bit >> odd, but there would be nothing preventing it codewise, outside of the >> oddity of ->prep() not being idempotent at that point. Don't follow why >> that would be necessary, though, can you expand? > > ->prep() doesn't export to uring cmd, and we may not want to bother > drivers. Sure, we don't want it off ->uring_cmd() or anything like that. > Also remove buffer still can't be done in ->prep(). I mean, technically it could... Same restrictions as add, however. > Not dig into further, one big thing could be that dependency isn't > respected in ->prep(). This is the main thing I was considering, because there's nothing preventing it from happening outside of the fact that it makes ->prep() not idempotent. Which is a big enough reason already, but... -- Jens Axboe
