On 2024-08-16 11:38, Jens Axboe wrote: > On 8/16/24 12:01 PM, David Wei wrote: >> diff --git a/io_uring/io_uring.h b/io_uring/io_uring.h >> index 9935819f12b7..e35fecca4445 100644 >> --- a/io_uring/io_uring.h >> +++ b/io_uring/io_uring.h >> @@ -41,6 +41,7 @@ struct io_wait_queue { >> unsigned cq_tail; >> unsigned nr_timeouts; >> ktime_t timeout; >> + bool no_iowait; >> >> #ifdef CONFIG_NET_RX_BUSY_POLL >> ktime_t napi_busy_poll_dt; > > I'd put that bool below the NAPI section, then it'll pack in with > napi_prefer_busy_poll rather than waste 7 bytes as it does here. > Thanks, I will remember to always check with pahole next time!