On 8/16/24 12:01 PM, David Wei wrote: > Add IORING_ENTER_NO_IOWAIT flag. If this is set then io_uring will not > set current->in_iowait prior to waiting. Ordering is a bit wrong here - with this patch, you can set IORING_ENTER_NO_IOWAIT and it will appear to work (eg no -EINVAL return), but it won't actually work. I'd just squash patch 1 + 2, as just having patch 2 with the uapi hunk be patch 1 leaves patch 2 as just adding it to the flags check. And at that point you'd probably just want to fold in patch 3 as well, not sure that makes sense as a separate patch. -- Jens Axboe