On 8/13/24 11:22 AM, Olivier Langlois wrote: > On Mon, 2024-08-12 at 14:40 -0600, Jens Axboe wrote: >> >> >>> 3. I am surprised to notice that in __io_napi_do_busy_loop(), >>> list_for_each_entry_rcu() is called to traverse the list but the >>> regular methods list_del() and list_add_tail() are called to update >>> the >>> list instead of their RCU variant. >> >> Should all just use rcu variants. >> >> Here's a mashup of the changes. Would be great if you can test - I'll >> do >> some too, but always good with more than one person testing as it >> tends >> to hit more cases. >> > Jens, > > I have integrated our RCU corrections into > https://lore.kernel.org/io-uring/5fc9dd07e48a7178f547ed1b2aaa0814607fa246.1723567469.git.olivier@xxxxxxxxxxxxxx/T/#u > > and my testing so far is not showing any problems... > but I have a very static setup... > I had no issues too without the corrections... Thanks for testing, but regardless of whether that series would go in or not, I think those rcu changes should be done separately and upfront rather than be integrated with other changes. -- Jens Axboe
