On Mon, Jun 10, 2024 at 02:18:34AM +0100, Pavel Begunkov wrote: > On 5/11/24 01:12, Ming Lei wrote: > > Add helper of io_req_commit_cqe() which can be used in posting CQE > > from both __io_submit_flush_completions() and io_req_complete_post(). > > Please drop this patch and inline further changes into this > two callers. There are different locking rules, different > hotness, and should better be left duplicated until cleaned > up in a proper way. Yes, the helper is just for making following code more clean & readable. Actually it changes nothing for __io_submit_flush_completions(), but io_req_complete_post() can be thought as non-fast path. And we may keep it only friendly for __io_submit_flush_completions(), meantime just cover io_req_complete_post(). Thanks, Ming
