Re: [PATCH liburing v2] test: add test cases for hugepage registered buffers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2024-05-30 14:51 UTC, Jens Axboe wrote:
> Thanks for improving the test case. Note on the commit message - use
> '---' as the separator, not a random number of '-' as it would otherwise
> need hand editing after being applied.

Will pay attention next time.

> This is against a really old base, can you resend it so it applies to
> the current tree? Would not be hard to hand apply, but it's a bit
> worrying if your tree is that old.

Sure, will rebase it.

> Outside of that, if you get ENOMEM on mmap'ing a huge page because the
> system doesn't have huge pages allocated (quite common), the test case
> should print an information message and return T_EXIT_SKIP to skip the
> test case rather than hard failing.
> 
> A few other comments below.

Will fix these issues. Thanks!





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux