On Thu, Mar 28, 2024 at 12:18:06PM +1100, Dave Chinner wrote: > > if (!(kiocb->ki_flags & IOCB_DIRECT) && > > - !(kiocb->ki_filp->f_mode & FMODE_BUF_WASYNC) && > > + !fops_buf_wasync(kiocb->ki_filp) && > > (req->flags & REQ_F_ISREG)) > > goto copy_iov; > > You should probably also fix that comment - WASYNC is set when the > filesystem supports NOWAIT for buffered writes. The existing indentation is also horribly wrong here, might be owrth fixing if we touch it anyway..