On 2024-03-22 11:50, Kanchan Joshi wrote: > From: Anuj Gupta <anuj20.g@xxxxxxxxxxx> > > Get rid of the flags field in io_rw. Flags can be set in kiocb->flags > during prep rather than doing it while issuing the I/O in io_read/io_write. > > Signed-off-by: Anuj Gupta <anuj20.g@xxxxxxxxxxx> > --- > io_uring/rw.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) This patch looks fine and is a no-op on its own, but I think there is a subtle semantic change. If the rw_flags is invalid (i.e. kiocb_set_rw_flags() returns an err) and prep() fails, then the remaining submissions won't be submitted unless IORING_SETUP_SUBMIT_ALL is set. Currently if kiocb_set_rw_flags() fails in prep(), only the request will fail.
