On Fri, 08 Mar 2024 19:32:56 -0500, Gabriel Krisman Bertazi wrote:
> Commit 3fcb9d17206e ("io_uring/sqpoll: statistics of the true
> utilization of sq threads"), currently in Jens for-next branch, peeks at
> io_sq_data->thread to report utilization statistics. But, If
> io_uring_show_fdinfo races with sqpoll terminating, even though we hold
> the ctx lock, sqd->thread might be NULL and we hit the Oops below.
>
> Note that we could technically just protect the getrusage() call and the
> sq total/work time calculations. But showing some sq
> information (pid/cpu) and not other information (utilization) is more
> confusing than not reporting anything, IMO. So let's hide it all if we
> happen to race with a dying sqpoll.
>
> [...]
Applied, thanks!
[1/1] io_uring: Fix sqpoll utilization check racing with dying sqpoll
commit: 606559dc4fa36a954a51fbf1c6c0cc320f551fe0
Best regards,
--
Jens Axboe
