Re: [PATCH 1/1] io_uring: fix mshot read defer taskrun cqe posting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/7/24 13:33, Jens Axboe wrote:
On 3/6/24 9:02 AM, Pavel Begunkov wrote:
We can't post CQEs from io-wq with DEFER_TASKRUN set, normal completions
are handled but aux should be explicitly disallowed by opcode handlers.

Looks good - but I can't help but think that it'd be nice to handle this
from io_wq_submit_work() instead, and take it out of the opcode
handlers themselves (like this one, and the recv/recvmsg part). That'd
put it in the slow path instead.

I have a follow up cleanup patch, but I like this idea even more


Anyway, it's applied, as it's a real fix and any work like the above
should be done separately of course.

--
Pavel Begunkov




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux