On Fri, 2024-02-02 at 13:14 -0700, Jens Axboe wrote: > > Ah gotcha, yeah that’s odd and could not ever have worked. I wonder > how that was tested… > > I’ll setup a liburing branch as well. > It is easy. You omit to check the function return value by telling to yourself that it cannot fail... I caught my mistake on a second pass code review... C++ has a very useful [[nodiscard]] attribute that can help to catch this simple error... I am not sure if there is something similar to the [[nodiscard]] in the ISO C standard...