Re: [PATCH 2/2] io_uring: do not clamp read length for multishot read

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/5/23 3:30 PM, Dylan Yudaken wrote:
> When doing a multishot read, the code path reuses the old read
> paths. However this breaks an assumption built into those paths,
> namely that struct io_rw::len is available for reuse by __io_import_iovec.
> 
> For multishot this results in len being set for the first receive
> call, and then subsequent calls are clamped to that buffer length incorrectly.

Should we just reset this to 0 always in io_read_mshot()? And preferably
with a comment added as well as to why that is necessary to avoid
repeated clamping.

-- 
Jens Axboe





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux