For addr: this field is not used, since buffer select is forced. But by forcing
it to be zero it leaves open future uses of the field.
len is actually usable, you could imagine that you want to receive
multishot up to a certain length.
However right now this is not how it is implemented, and it seems
safer to force this to be zero.
Fixes: fc68fcda0491 ("io_uring/rw: add support for IORING_OP_READ_MULTISHOT")
Signed-off-by: Dylan Yudaken <dyudaken@xxxxxxxxx>
---
io_uring/rw.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/io_uring/rw.c b/io_uring/rw.c
index 1c76de483ef6..ea86498d8769 100644
--- a/io_uring/rw.c
+++ b/io_uring/rw.c
@@ -111,6 +111,13 @@ int io_prep_rw(struct io_kiocb *req, const struct io_uring_sqe *sqe)
rw->len = READ_ONCE(sqe->len);
rw->flags = READ_ONCE(sqe->rw_flags);
+ if (req->opcode == IORING_OP_READ_MULTISHOT) {
+ if (rw->addr)
+ return -EINVAL;
+ if (rw->len)
+ return -EINVAL;
+ }
+
/* Have to do this validation here, as this is in io_read() rw->len might
* have chanaged due to buffer selection
*/
--
2.41.0
