On 9/13/23 1:36 PM, Jens Axboe wrote: > On 9/13/23 9:27 AM, Breno Leitao wrote: >> Add support for getsockopt command (SOCKET_URING_OP_GETSOCKOPT), where >> level is SOL_SOCKET. This is similar to the getsockopt(2) system >> call, and both parameters are pointers to userspace. >> >> Important to say that userspace needs to keep the pointer alive until >> the CQE is completed. > > Since it's holding the data needed, this is true for any request that > is writing data. IOW, this is not unusual and should be taken for > granted. I think this may warrant a bit of rewording if the patch is > respun, if not then just ignore it. reads data of course, writing into the userspace buffer. -- Jens Axboe
