On 7/12/23 2:58?AM, Peter Zijlstra wrote: > On Tue, Jul 11, 2023 at 06:47:00PM -0600, Jens Axboe wrote: >> In preparation for having another waker that isn't futex_wake_mark(), >> add a wake handler in futex_q. No extra data is associated with the >> handler outside of struct futex_q itself. futex_wake_mark() is defined as >> the standard wakeup helper, now set through futex_q_init like other >> defaults. > > Urgh... so if I understand things right, you're going to replace this > with a custom wake function that does *NOT* put the task on the wake_q. > > The wake_q will thus be empty and the task does not get woken up. I'm > presuming someone gets a notification instead somewhere somehow. Right. The custom wake function is responsible for waking the task, if that is what needs to happen. On the io_uring side, the callback would queue work for the original task to post a completion event, which would then also wake it up obviously. > I might've been nice to mention some of this somewhere ... I'll expand the commit message a bit, it is a bit light. -- Jens Axboe
