On Wed, Jul 12, 2023 at 04:03:41PM +0800, Hao Xu wrote: > On 7/11/23 21:02, Ammar Faizi wrote: > > On Tue, Jul 11, 2023 at 07:40:25PM +0800, Hao Xu wrote: > > > Co-developed-by: Stefan Roesch <shr@xxxxxx> > > > Signed-off-by: Stefan Roesch <shr@xxxxxx> > > > Signed-off-by: Dominique Martinet <asmadeus@xxxxxxxxxxxxx> > > > --- > > > > Since you took this, it needs your Signed-off-by. > > > > Hi Ammar, > I just add this signed-off-by of Stefan to resolve the checkpatch complain, > no code change. Both, you and Stefan are required to sign-off. The submitter is also required to sign-off even if the submitter makes no code change. See https://www.kernel.org/doc/html/latest/process/submitting-patches.html: """ Any further SoBs (Signed-off-by:'s) following the author's SoB are from people handling and transporting the patch, but were not involved in its development. SoB chains should reflect the real route a patch took as it was propagated to the maintainers and ultimately to Linus, with the first SoB entry signalling primary authorship of a single author. """ It also applies to the maintainer when they apply your patches. -- Ammar Faizi