On Tue, 2023-05-09 at 09:19 -0600, Jens Axboe wrote: > The socket read/write functions deal with O_NONBLOCK and IOCB_NOWAIT > just fine, so we can flag them as being FMODE_NOWAIT compliant. With > this, we can remove socket special casing in io_uring when checking > if a file type is sane for nonblocking IO, and it's also the defined > way to flag file types as such in the kernel. > > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx> > Cc: Eric Dumazet <edumazet@xxxxxxxxxx> > Cc: Jakub Kicinski <kuba@xxxxxxxxxx> > Cc: netdev@xxxxxxxxxxxxxxx > Signed-off-by: Jens Axboe <axboe@xxxxxxxxx> > --- > net/socket.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/socket.c b/net/socket.c > index a7b4b37d86df..6861dbbfadb6 100644 > --- a/net/socket.c > +++ b/net/socket.c > @@ -471,6 +471,7 @@ struct file *sock_alloc_file(struct socket *sock, int flags, const char *dname) > return file; > } > > + file->f_mode |= FMODE_NOWAIT; > sock->file = file; > file->private_data = sock; > stream_open(SOCK_INODE(sock), file); The patch looks sane to me: Reviewed-by: Paolo Abeni <pabeni@xxxxxxxxxx> I understand the intention is merging patch via the io_uring tree? If so, no objections on my side: hopefully it should not cause any conflicts with the netdev tree. Thanks, Paolo
